Merged
Conversation
JPHutchins
requested review from
JerryCapistrano,
KungFuSensai,
aldenhaase,
Copilot,
davedesro,
klam20,
robhelvestine and
swoisz
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #77 by implementing proper MSS (Maximum Segment Size) calculation instead of using MTU directly for UDP transport. The change prevents fragmentation by accounting for IPv4/IPv6 and UDP header overhead when determining maximum payload size.
- Adds IPv4/IPv6 auto-detection to calculate appropriate overhead (28 bytes for IPv4, 48 bytes for IPv6)
- Implements proper MSS calculation by subtracting protocol overhead from MTU per RFC 8085
- Updates configuration files for improved linting and VS Code settings
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| smpclient/transport/udp.py | Implements MSS calculation with IPv4/IPv6 detection and protocol overhead constants |
| tests/test_smp_udp_transport.py | Adds comprehensive tests for MSS calculation and IPv4/IPv6 detection |
| envr-default | Updates lint command to show diff output for isort |
| .vscode/settings.json | Updates VS Code settings for isort integration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.