Skip to content

fix: ble: Race condition in receive for notifications #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JPHutchins merged 1 commit into from
Oct 27, 2025
Merged

fix: ble: Race condition in receive for notifications #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions smpclient/transport/ble.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,9 @@ async def receive(self) -> bytes:
# self._notify_condition is used to synchronize access to self._buffer.

async with self._notify_condition: # wait for the header
logger.debug(f"Waiting for notify on {SMP_CHARACTERISTIC_UUID=}")
await self._notify_or_disconnect()

if len(self._buffer) < smphdr.Header.SIZE: # pragma: no cover
raise SMPBLETransportException(
f"Buffer contents not big enough for SMP header: {self._buffer=}"
)
while len(self._buffer) < smphdr.Header.SIZE:
logger.debug(f"Waiting for notify on {SMP_CHARACTERISTIC_UUID=}")
await self._notify_or_disconnect()

header: Final = smphdr.Header.loads(self._buffer[: smphdr.Header.SIZE])
logger.debug(f"Received {header=}")
Expand Down
Loading