Skip to content

Rails Health Controller monkey patch#79

Open
oz-tal wants to merge 1 commit intointerdiscipline:mainfrom
oz-tal:rails-health-controller-fix
Open

Rails Health Controller monkey patch#79
oz-tal wants to merge 1 commit intointerdiscipline:mainfrom
oz-tal:rails-health-controller-fix

Conversation

@oz-tal
Copy link

@oz-tal oz-tal commented Feb 8, 2025

I'd like to suggest this change to address this issue: #77

Override the lockup check method to do nothing in the Rails health controller.

According to my test, using skip_before_action trigger the rescue_from(Exception) defined here, even with the raise: false option. For this reason, overriding the check seem appropriate instead.

This simple monkey-patch should gracefully do nothing on older version of Rails where the Rails::HealthController doesn't exist.

Override the lockup check method to do nothing in the Rails health controller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant