Added type attribute on app when a column does not contain a variant.#46
Open
raffazizzi wants to merge 1 commit intointeredition:masterfrom
Open
Added type attribute on app when a column does not contain a variant.#46raffazizzi wants to merge 1 commit intointeredition:masterfrom
raffazizzi wants to merge 1 commit intointeredition:masterfrom
Conversation
Collaborator
|
I think this is an improvement. It doesn't seem to break anything, and since XML output is likely to be chosen in situations that will undergo subsequent processing with XSLT anyway, and that is likely to care about the presence or absence of variation, it relieves the downstream process of having to check for the presence or absence of variation within the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, @ebeshero and I have been working on a collation and realized that it would be necessary for us to know whether a table object row contains normalized tokens that agree or not. So we added an attribute to
<app>in the XML output that indicates whether the children<rdg>s agree. Example:In the example above the string
<lb/>is set to be normalized away during the collation process; yet we need to see it in the output for project-specific reasons. This way would indicate alignment but keep the witnesses separate.For further reference, you can find our project here: https://github.com/ebeshero/Pittsburgh_Frankenstein/tree/Text_Processing