Skip to content

chore: upgrade to polkadot 0.9.16#484

Merged
gregdhill merged 2 commits intomasterfrom
feat/upgrade-0.9.16
Feb 1, 2022
Merged

chore: upgrade to polkadot 0.9.16#484
gregdhill merged 2 commits intomasterfrom
feat/upgrade-0.9.16

Conversation

@sander2
Copy link
Member

@sander2 sander2 commented Jan 31, 2022

  • [BREAKING] added preimage pallet.The scheduler pallet changed, forcing a change in our code. We have two options: either we add the new preimage pallet or we use the default implementation. In the latter case, behavior would be unchanged. However, I went with the first option because it gives greater flexability: the current behavior is unchanged, but it makes it possible to schedule a call (e.g. runtime upgrade) without immediately uploading it. Rather, you would give a hash of the call, and upload it later. This allows democracy to be more efficient in the future because you don't need to upload a new runtime just to make the proposal. This will still require a change in our democracy pallet, but it will not be a breaking change for our clients.
  • Added migration for the scheduler pallet (better safe than sorry)
  • Updated handling of xcm paths: they may now get canonicalized and we need to be able to handle both the old and the new representation. Preimage registrar and Scheduler integration paritytech/substrate#10356
  • Pallets now need all storage items to implement MaxEncodedLen by default. I tried to implement this where possible, but I ran into an problem where fixedpoint types do not implement it. I opened an issue on the substrate repo for this. Also, our usage of sets and vecs would complicate implementing it anyway. In the future we might want to see if we can find alternatives to the vec usage in e.g. the vault struct. In the end I resorted to opting out of the requirement by using #[pallet::without_storage_info] for most pallets.
  • Upgraded compiler version. I was getting cargo errors complaining that named-profiles was not yet stabilized.
  • Lots of smaller changes

@sander2 sander2 force-pushed the feat/upgrade-0.9.16 branch from b2c22b6 to a2c5bd2 Compare February 1, 2022 05:54
@sander2 sander2 force-pushed the feat/upgrade-0.9.16 branch from a2c5bd2 to 83f2835 Compare February 1, 2022 06:23
@gregdhill gregdhill marked this pull request as ready for review February 1, 2022 09:52
@gregdhill
Copy link
Member

gregdhill commented Feb 1, 2022

Notes:

  • AccountId no longer implements Default
  • Runtime version now includes state_version

@gregdhill gregdhill merged commit bb7407a into master Feb 1, 2022
@gregdhill gregdhill deleted the feat/upgrade-0.9.16 branch February 1, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants