Conversation
b2c22b6 to
a2c5bd2
Compare
a2c5bd2 to
83f2835
Compare
gregdhill
approved these changes
Feb 1, 2022
Member
|
Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaxEncodedLenby default. I tried to implement this where possible, but I ran into an problem where fixedpoint types do not implement it. I opened an issue on the substrate repo for this. Also, our usage of sets and vecs would complicate implementing it anyway. In the future we might want to see if we can find alternatives to the vec usage in e.g. the vault struct. In the end I resorted to opting out of the requirement by using#[pallet::without_storage_info]for most pallets.named-profileswas not yet stabilized.