Merged
Conversation
sander2
force-pushed
the
chore/polkadot-0.9.38
branch
from
24d266b to
a27c7bf
Compare
sander2
force-pushed
the
chore/polkadot-0.9.38
branch
from
a27c7bf to
b4fb898
Compare
gregdhill
reviewed
Apr 18, 2023
| pub DotPerSecond: (AssetId, u128) = (MultiLocation::parent().into(), dot_per_second()); | ||
| pub CanonicalizedIntrPerSecond: (AssetId, u128) = ( | ||
| pub DotPerSecond: (AssetId, u128, u128) = (MultiLocation::parent().into(), dot_per_second(), | ||
| 0, // todo: determine how much to charge per mb of proof |
Member
There was a problem hiding this comment.
Is this something we should do before merging @sander2?
Member
Author
There was a problem hiding this comment.
Let's keep 0 for now to avoid breaking integrations with partners - the 0.9.38 is risky enough by itself with all its changes. We can revisit in the future. Acala also has it set to 0 fwiw
Comment on lines
+182
to
+185
| RuntimeCall::Issue(..) | RuntimeCall::Replace(..) | RuntimeCall::Redeem(..) | RuntimeCall::BTCRelay(..) => { | ||
| // disallow anything to do with btc transactions since btc tx may be unbounded | ||
| false | ||
| } |
Member
There was a problem hiding this comment.
We should remember to change this once the weight refactoring is complete.
Member
Author
There was a problem hiding this comment.
It still wouldn't meet requirement #3 as I understand it (Have a defined proof size weight, e.g. no unbounded vecs in call parameters.)
Co-authored-by: Greg Hill <gregorydhill@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the changes in this upgrade are due to the xcm v3 upgrade. Tested XCM with chopsticks.
See:
This PR supersedes #960 since we want to have this on the interlay repo for upcoming weight fixes