[BREAKING] fix: allow vault to withdraw all collateral#991
Merged
gregdhill merged 2 commits intointerlay:masterfrom Jul 20, 2023
Merged
[BREAKING] fix: allow vault to withdraw all collateral#991gregdhill merged 2 commits intointerlay:masterfrom
gregdhill merged 2 commits intointerlay:masterfrom
Conversation
Member
|
please fix the ci |
gregdhill
force-pushed
the
fix/withdraw-all
branch
from
5278876 to
311381b
Compare
gregdhill
force-pushed
the
fix/withdraw-all
branch
4 times, most recently
from
4ddf5fa to
2ee97b9
Compare
Member
|
Can you add a test that fails on the current code, but succeeds on this branch? |
gregdhill
force-pushed
the
fix/withdraw-all
branch
from
2ee97b9 to
827de2f
Compare
gregdhill
commented
Jun 21, 2023
sander2
changed the title
gregdhill
force-pushed
the
fix/withdraw-all
branch
4 times, most recently
from
5750083 to
d40fe09
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
fix/withdraw-all
branch
from
d40fe09 to
9cfca0b
Compare
sander2
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hacky fix to allow Vaults to withdraw all collateral since #974 unintentionally introduced a bug that prevents this. Specifically, due to a loss in precision the calculation in
withdraw_stake(apply_slash) may produce a smaller amount thanTotalCurrentStakewhich results in theInsufficientFundserror.