Conversation
Deployment results
Logs #23189903025 |
DarianM
commented
Feb 27, 2026
kjmitchelljr
approved these changes
Mar 19, 2026
Collaborator
kjmitchelljr
left a comment
kjmitchelljr
left a comment
There was a problem hiding this comment.
Small nits here and there, but overall the PR looks good
Collaborator
There was a problem hiding this comment.
Are there other locales to be added here in the short-term or will his be built out in the future?
| "status": { | ||
| "connect": "If you're connecting your wallet address for the first time, you'll start with the default profile. You can then customize and save your profile as needed.", | ||
| "no_saved_profiles": "There are no custom edits for the {{toolName}} correlated to this wallet address but you can start customizing when you want.", | ||
| "profiles_fetched": "We've loaded your profiles. Feel free to keep customizing your {{toolName}} to fit your style." |
Collaborator
There was a problem hiding this comment.
nit: curious reasoning for snake_case here versus camelCase
|
|
||
| export function useI18n() { | ||
| return useContext(I18nContext) | ||
| } |
Collaborator
There was a problem hiding this comment.
nit: adding I18nContext.displayName = 'I18nContext for debugging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #482