chore(migration/001): convert legacy configuration to the new format#641
Merged
chore(migration/001): convert legacy configuration to the new format#641
Conversation
Deployment results
Logs #24672982760 |
sidvishnoi
reviewed
Mar 31, 2026
DarianM
commented
Apr 1, 2026
sidvishnoi
reviewed
Apr 1, 2026
DarianM
changed the title
sidvishnoi
reviewed
Apr 16, 2026
Comment on lines
+6
to
+7
| const LEGACY_PREFIX = '20250717-dev' | ||
| const NEW_PREFIX = '20260305-dev' |
Collaborator
There was a problem hiding this comment.
Still going through to understand changes, but should these be environment variables or stored in a different way or is this something only going to be ran once and no further change would be required?
Member
There was a problem hiding this comment.
They're specific to each migration.
sidvishnoi
reviewed
Apr 17, 2026
sidvishnoi
reviewed
Apr 17, 2026
sidvishnoi
approved these changes
Apr 17, 2026
Member
sidvishnoi
left a comment
sidvishnoi
left a comment
There was a problem hiding this comment.
Looks good to me. Let's do a screen share when you run this migration.
sidvishnoi
changed the title
sidvishnoi
changed the title
sidvishnoi
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
one-time CLI to migrate legacy S3 config data to the new format
migrationsCLI that reads wallet configs from the legacy S3 prefix, converts them to the new shape, writes them to the new prefix.Adds migrations/s3/ as a standalone S3 client package wrapping client-s3, shared by the CLI.
Includes a dry-run mode (--dry-run) that simulates all S3 writes/deletes without touching real data, and writes its own separate log file.
Each run produces a timestamped log file under migrations recording successful, skipped, and failed wallets.
Migration packages are excluded from the root pnpm workspace — they live under their own migrations/pnpm-workspace.yaml and are installed separately (cd migrations && pnpm install), so CI is not affected