Merged
Conversation
6 tasks
github-actions
bot
added
package: wallet/backend
dragosp1011
reviewed
Oct 31, 2025
| if (!data.currencyExponent) throw new Error('Missing currency exponent') | ||
|
|
||
| // Only EUR (0978) is supported for now | ||
| const currency = uint8ArrayToHex(data.currencyCode) |
Contributor
There was a problem hiding this comment.
I think we allow any currency?
Contributor
Author
There was a problem hiding this comment.
yes, ignore that, we allow any currency. The currencyCode is not verified against anything from the webhook/outgoingPayment details so it's flexible.
dragosp1011
reviewed
Oct 31, 2025
dragosp1011
reviewed
Oct 31, 2025
dragosp1011
reviewed
Oct 31, 2025
cozminu
changed the title
dragosp1011
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Changes