Create readonly postgres user for solrupdater#2150
Merged
mekarpeles merged 3 commits intointernetarchive:masterfrom May 28, 2019
Merged
Create readonly postgres user for solrupdater#2150mekarpeles merged 3 commits intointernetarchive:masterfrom
mekarpeles merged 3 commits intointernetarchive:masterfrom
Conversation
Contributor
|
LGTM (confirming what I communicated via Slack) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix: Creates a readonly postgres user for solrupdater so there's a stronger guarantee that when we run this on logs ~1mo out-of-date (for the last phase of #1843 ) it won't be causing any unintentional database edits.
Technical
peer; this requires us to create a system user but means we don't need a password (good for dev). On production we'll have to give the postgres user a password somehow?readcreateuser; it can still create new tables. Removing this seemed like more trouble than it's worth (especially if we want to keep prod in sync), so didn't bother.Testing
web.ctx.site.save, but this never worked from solrupdater because there's no ol account associated with it.solrupdaternew-solr-updaterfailed (as expected).