Update navigation handling so pages keep state when switching between them. #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwr1
requested changes
Mar 16, 2025
Member
jwr1
left a comment
jwr1
left a comment
There was a problem hiding this comment.
Thank you! Just a few points:
- Going to the settings and switching accounts seemed to cause a weird state where the screen would switch back to the feed view (without pressing anything) while the navigation would still have the settings highlighted. Ideally, it just wouldn't switch at all.
- Could you also have the state refresh on profile switch? There are a lot of default settings that could potentially change when the profile is switched, so a refresh would be needed in order to inherit those changes.
Member
|
Maybe have the profile state refresh in |
Add refresh on profile switch.
Contributor
Author
|
Should be fixed now. Moved the refresh trigger down a level in the widget hierarchy so "Feed", "Explore" and "Account" screens are refreshed rather than the whole app. Should prevent the screen switching on refresh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should keep state when switching between pages on the navigation bar as well as between feed tabs.
Adds a callback to refresh widgets state when switching between accounts.