Add support for marking posts as read #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option in behaviour settings to hide read posts. Add swipe action to toggle read status of post. Add option to content_menu to toggle read status of post.
jwr1
requested changes
Apr 24, 2025
Member
jwr1
left a comment
jwr1
left a comment
There was a problem hiding this comment.
Thanks, looks nice! I did end up having a lot of comments this time though.
Remove redundant `post_id` parameter from lemmy api mark_as_read. Change isRead query to use composite filter. Make Post read parameter non-nullable. Delete associated read posts from db on account deletion. Switch content_menu markRead text between "Mark as Read" and "Mark as Unread" depending on read status. Add new setting to feed actions screen for hideReadPosts. Move hideReadPosts from behaviour screen to feed defaults screen.
jwr1
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For lemmy just uses lemmy api to mark as read.
For all other account types read status is stored in a sembast store.
Posts are marked on read when opened or through swiping or the menu.
Also added feed actions to quickly show/hide read posts in the feed.
Closes #105