Skip to content

Conversation

@olorin99
Copy link
Contributor

Closes #134

Copy link
Member

@jwr1 jwr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few points:

  • I can't really imagine a case where having the option to control both the vote widgets and the comment widgets separately would be useful, so I'd say the option to hide them should be combined. Maybe something like "Hide action buttons" (hideActionButtons in the profile) or something similar.

  • I believe some sort of description/subtitle would also be helpful for this setting. Maybe something like:

    Hides the action buttons (vote, boost, reply, etc.) below each post and comment. The controls are still accessible in the overflow menu. It is recommended to enable swipe gestures in unison with this setting.

  • It looks like the icon for the new setting toggle needs to be updated, as it's just the same as the one above it.

  • Can you also add the notification controls to hide when this settings is enabled?

  • Can you add a reply button to the overflow menu? I'm just thinking if somebody did enable this setting but did not enable swipe gestures, then there'd be no way to reply to anything.

olorin99 added 2 commits May 1, 2025 08:31
New setting also hides notification controls.
Add subtitle to hide action buttons setting.
@olorin99
Copy link
Contributor Author

Moved the inkwell that opens the overflow menu into content_item since onReply sets the content item state. The reply action won't be available from a collapsed comments overflow menu but I figure users shouldn't be able to reply to hidden content anyway so its alright.

@olorin99 olorin99 requested a review from jwr1 April 30, 2025 23:01
@jwr1 jwr1 merged commit 03dcfd6 into main Apr 30, 2025
2 checks passed
@jwr1 jwr1 deleted the hide_post_buttons branch April 30, 2025 23:23
@jwr1 jwr1 mentioned this pull request Apr 30, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to hide action buttons

3 participants