Notifications Support for Piefed #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwr1
requested changes
May 5, 2025
Member
jwr1
left a comment
jwr1
left a comment
There was a problem hiding this comment.
Thank you!
You working on this made me realize some of the notification code needs to be reworked a bit, but I'll do that separately.
It seems preferred.social still hasn't updated, so I won't be able to test it quite yet. Here are my initial thoughts, though.
Contributor
Author
|
note - converted back to draft to work on the |
JollyDevelopment
force-pushed
the
jollydev/piefed-notifications-00
branch
from
c120bdc to
ff8d582
Compare
jwr1
requested changes
May 11, 2025
Co-authored-by: jwr1 <47087725+jwr1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for notifications for Piefed.
In coordination with this PR on Piefed: https://codeberg.org/rimu/pyfedi/pulls/615 (now merged), and https://codeberg.org/rimu/pyfedi/pulls/619.
It's mostly based on the way the
.fromMbinfunctions are setup, except the NotificationItem model which does a switch on the notificationtype more like the lemmy way.I tested it on my personal piefed instance and its working so far.
Works for the Linux client and the android app in my testing.