Add "mark post on scroll" option. #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle cases where entire pages in feed are either filtered out or read.
jwr1
reviewed
May 7, 2025
jwr1
reviewed
May 7, 2025
jwr1
requested changes
May 7, 2025
Member
jwr1
left a comment
jwr1
left a comment
There was a problem hiding this comment.
While testing, I enabled the two new settings and went back to the feed and waited for a second (expecting to see the posts on screen to be marked as read), but nothing happened. I also tried scrolling down slowly to see if that would do something, but it did not.
Am I misinterpreting what this setting does? Or am I doing something wrong?
I'll do a more thorough review once I can get it working.
Fix not marking posts as read when scrolling with scroll wheel.
Contributor
Author
|
Posts are marked as read when they are scrolled up and offscreen. There was a bug where posts weren't marked as read when scrolling with the scroll wheel on desktop but that should be fixed now. |
jwr1
reviewed
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds options to mark posts read on scroll. It also adds some logic to handle cases when multiple pages of read posts are encountered. When fetching a new page in the feed, if the page is empty due to all the posts being filtered out or read then it will try to read another page. If this page is also empty then it will treat it as reaching the end of recent posts and notify the user they have "caught up" on recent posts and ask if they want to try loading older posts. This is likely to only happen on less busy feeds such as in magazine feeds or the subscribed microblog feed.