New chat button. #235
New chat button. #235
Conversation
Change user screen send message from inline to open message thread screen. Add piefed send message api.
jwr1
left a comment
jwr1
left a comment
There was a problem hiding this comment.
Looks good, just a few things:
- The title for the new chat page shouldn't be "User Follows".
- On the new chat page, the "People" option is visible, albeit the only option, but it probably shouldn't be there at all, considering you can't message any other explore type.
- On Mbin, if I create a new chat after searching a user, and then send a message, if I send more than one message at once (while still on that screen), it will create multiple new chats, instead of using the same one. I believe what we need to do here is to use the
createmessage API on the first send, and thenpostThreadReplyon all subsequent messages sent on that screen.
Just a note, I'm not exactly sure what the 403 errors you were running into earlier were caused by, but could it be due to an existing message thread already existing with an account?
Hide search options when search mode is set. Save threadId when creating new chat so following messages use reply endpoint. Show other users username in appbar when creating new chat.
jwr1
left a comment
jwr1
left a comment
There was a problem hiding this comment.
Ok, just one more thing to add. If I create a new chat, and then go back to the messages screen, then the new chat doesn't show up yet until the message list is reloaded, which is a problem considering how difficult it is to get it reloaded on desktop. On mobile, you would just pull to refresh, but that doesn't work on desktop. Before the screen state caching was added, you'd just be able to switch to a different tab and then switch back, but that obviously doesn't work anymore.
Anyway, how about if a new chat is created, then the message list screen should just be refreshed automatically?
On PieFed and Lemmy when navigating to a message thread from the user screen it should fill with the previous messages with the user however on Mbin there isn't a way to map a user id to a message thread id so can only get previous messages when navigating from the messages screen.