-
-
Notifications
You must be signed in to change notification settings - Fork 17
Migrate to sql backed database #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Store feeds in the new database.
Rename some tables.
|
I still need to do more thorough testing and make sure all weird database states migrate across properly but otherwise this should be ready for review. With migrating from the old database to the new one I skip over migrating the feedCache since I got some weird errors when trying and figured that since it would just be recreated automatically when a user opens a feed it wasn't necessary. Every other sembast store should be migrated over though. |
Make filterlist objects insertable.
Store datetime as strings. Switch isPushRegistered as non nullable and default to false.
|
I didn't see any other issues. After it's merged, I'll probably install a dev version on my phone just to see if I notice anything through daily use, since this is a pretty big change. |
Remove unneeded unique constraint on misc primary key. Add ReferenceName annotations to prevent name clashes.
jwr1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this migration, it looks great!
Migrate from using a nosql database to an sql database. Using the drift package
Stores to migrate
Other functionallity