Misc fixes #313
Merged
Misc fixes #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix null on account selection screen.
jwr1
approved these changes
Nov 25, 2025
jwr1
reviewed
Dec 3, 2025
| account.split('@').first.isNotEmpty, | ||
| (!widget.onlyNonGuestAccounts || | ||
| account.split('@').first.isNotEmpty) && | ||
| account.isNotEmpty, |
Member
There was a problem hiding this comment.
Wait a second, I took another look at this because I was running into this issue, but there should never be an account that's just an empty handle anyway. So we shouldn't even have to check it here.
This was referenced Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix create account with null handle.
Fix null access when empty account on account selection screen. Might fix #263 but not sure if same bug.