Skip to content

Conversation

@olorin99
Copy link
Contributor

Adds support for markdown embedded videos. Mostly see coming from mastodon.
Example post.
Also adds a setting to toggle auto play for videos.

Adds support for markdown embedded videos.
@olorin99
Copy link
Contributor Author

Also wanted to ask about the process for adding localized strings. Do I just add to the app_en.arb file?

@jwr1
Copy link
Member

jwr1 commented Jan 27, 2025

Also wanted to ask about the process for adding localized strings. Do I just add to the app_en.arb file?

Yes that's correct. For English, you add to app_en.arb, for any other language, you have to add it through weblate.

@jwr1
Copy link
Member

jwr1 commented Jan 27, 2025

Once the translation string is added, I'd say this looks good!

I will say, it would make sense to also have inline YouTube video detection and support, but you don't have to add that if you don't want to.

@olorin99
Copy link
Contributor Author

Not super confident with the youtube handling but should work.

Copy link
Member

@jwr1 jwr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! On my device, it's having trouble fetching the YouTube streaming links, but I know that's nothing to do with this. I'll look at that seperatly.

@jwr1 jwr1 merged commit b920235 into main Jan 28, 2025
2 checks passed
@jwr1 jwr1 deleted the markdown_video branch January 28, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants