Skip to content

Add support of Listing KPI#98

Closed
jakcpto wants to merge 25 commits into
intersystems-community:masterfrom
teccod:master
Closed

Add support of Listing KPI#98
jakcpto wants to merge 25 commits into
intersystems-community:masterfrom
teccod:master

Conversation

@jakcpto
Copy link
Copy Markdown

@jakcpto jakcpto commented Mar 14, 2023

SQL calculates on backend side.
Simple test in SQL injection implemented

Frisle and others added 23 commits February 20, 2023 09:36
Added new endpoint to request drillthrough for kpi sql and handler method for sql.
FIX: added new endpoint and handler for sql
During testing, it turned out that duplication broke the entire Bug panel. Moved duplication specifically for KPI
FIX: display format data
The dimension of the cube is taken from the names of the axes. The solution needs to be tested on a pie chart, further work on the solution is possible
Related issue
intersystems-community/DeepSeeWeb#348
FIX: add fix for textMeters
Add some changes to improve
Correction. Method duplicated
Added logic to check if KPI have dataProperties.
Remove previous changes, add new. First solution do not work for multilple text meters but last one should work.
Added sortDir and sotrColumn to REST requests, added filters injection check, added kpi type check
Add one universal endpoint for KPI
@eduard93
Copy link
Copy Markdown

  1. Пожалуйста возвращайте статус из WriteDrillthroughJSONKPI и выводите его как json в KPIExecute или просто возвращайте ошибку из KPIExecute.
  2. Не надо писать ошибку на девайс в WriteDrillthroughJSONKPI.
  3. TestSQL метод не нужен, мы доверяем определению KPI на сервере.
  4. %ZEN.Auxiliary.altJSONSQLProvider:%WriteJSONFromSQL возвращает статус, его нужно обрабатывать (выкидывать выше)
  5. Возможно Prepare не нужен - мне кажется %WriteJSONFromSQL должен это проверять внутри

@eduard93
Copy link
Copy Markdown

eduard93 commented Apr 5, 2023

Closed for #100

@eduard93 eduard93 closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants