[deploy] Move locality to a common variable and make it mandatory #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-glu
force-pushed
the
move_locality
branch
2 times, most recently
from
08052b6 to
df5f0de
Compare
barroco
approved these changes
Jul 8, 2025
barroco
reviewed
Jul 8, 2025
barroco
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localityis now a mandatory variable.This PR move it out of the
crdbcontext and make it mandatory everywhere and pass it in helm charts.It need an explicit release note about setting it to the new location.
This PR follow #1211 , you may want to read only the last commit.