[yugabyte] Use a single ip per server/tmaster pair, cleanup loadbalancers #1259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR 'merge' the loadbalancer / ip into a common one for each pair of yugabyte 'master' and 'tserver' service.
They don't share common ports, so that simply done via that.
It update the terraform states to merge those (but separate DNS entries are kept to avoid confusion on yugabyte servers), tanka files and helm charts.
This also clean up in general unless loadblancers in tanka files and keep only the new, merged one.
Tested in an aws-tanka <-> gke-helm deployment, with a successfully cluster built.
Fix #1199