[fileutils] Download and cache dataset #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BenjaminPelletier
left a comment
BenjaminPelletier
left a comment
There was a problem hiding this comment.
This looks fine to me, but for sufficiently-capable servers, it seems like an If-Modified-Since header would avoid any TTL expectation mismatches.
Contributor
Author
|
Thank you very much for the suggestions which have been integrated in the last commit. |
BenjaminPelletier
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the source dataset retrieval. It includes a caching mechanism to allow users to not download the file at each execution for development purpose for instance.