Handle new coding style for optional fields (drop python < 3.10 support) #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-glu
force-pushed
the
handle_new_coding_style
branch
from
d9b1b8f to
cdd3233
Compare
the-glu
changed the title
mickmis
approved these changes
Aug 14, 2025
mickmis
left a comment
mickmis
left a comment
There was a problem hiding this comment.
This has the consequence of dropping python < 3.10 support. Python 3.9 will be EOL in two month, so I assumed it's fine, but it's possible to make the code compatible at the cost of readability ^^'
I think that is OK as this is mostly used within a Docker image provided InterUSS.
Could be worth mentioning that in the release notes of the monitoring repo when it is upgraded though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP604 introduced a new, cleaner version of declaration for optional field that some tools like to enforce.
This make the library compatible with such usage, it has been tested on the upgraded monitoring code base.
This has the consequence of dropping python < 3.10 support. Python 3.9 will be EOL in two month, so I assumed it's fine, but it's possible to make the code compatible at the cost of readability ^^'