[monitorlib/fetch/query_and_describe] Immediately fail queries targetting fake network locations #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This needs a bit more work. Will pass PR back in ready when it is. |
…ting fake network locations
mickmis
force-pushed
the
fetch-fake-netlocs
branch
from
eb97a09 to
d321ac4
Compare
BenjaminPelletier
approved these changes
Mar 26, 2025
Member
BenjaminPelletier
left a comment
BenjaminPelletier
left a comment
There was a problem hiding this comment.
It would probably be good to add the ability to change this behavior [via resource](
in a future PR as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to
fetcha feature to immediately fail without any actual attempt queries for network locations identified as fake. The default setting for that is set to testdummy.interuss.org.Hopefully this change will address #991 (see #991 (comment)).