[mock_uss] Fix incoming tracer notifications with non-Z time zones #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, part of mock_uss tracer's handling logic for operational intent notifications attempts to adjust timestamp strings to be timezone-naive by stripping off the trailing "Z" before converting them to datetimes in order to compare to now. This is problematic when timestamp strings use a time offset other than "Z" (e.g., "-07:00") because those timestamps are converted to timezone-aware datetimes which then raise an exception when compared to timezone-naive now.
This PR fixes this bug by simply letting
arrowhandle timestamp parsing so that there will never be timezone-naive/aware mismatches.