[uss_qualifier] cleanup subscription CRUD fragments #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
subs-fragments-doc-cleanup
branch
2 times, most recently
from
46217ed to
c0a5125
Compare
mickmis
approved these changes
Jul 14, 2025
Contributor
mickmis
left a comment
mickmis
left a comment
There was a problem hiding this comment.
Few minor comments and one thing that looks strange.
Otherwise LGTM
monitoring/uss_qualifier/scenarios/astm/utm/dss/fragments/sub/validate/positive_index.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/fragments/sub/validate/zero_index.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.md
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.md
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.md
Show resolved
Hide resolved
|
|
||
| If the version of the subscription is updated without there having been any mutation of the subscription, the DSS is in violation of **[astm.f3548.v21.DSS0005,5](../../../../../../../requirements/astm/f3548/v21.md)**. | ||
|
|
||
| ## [Positive index](positive_index.md) |
Contributor
There was a problem hiding this comment.
Why does the 'non-mutated' step fragment should necessarily expected a positive notification index?
Contributor
There was a problem hiding this comment.
Also: make it more explicit that this is about the notification index.
Contributor
Author
There was a problem hiding this comment.
The index may change for reasons outside of uss_qualifier's control or awareness, therefore the only thing we can reliably verify with regard to the notification index is that:
- it should be there
- on creation of the entity it should be 0
- after creation, it should be 0 or greater
(I'll basically add the above to the relevant fragments)
monitoring/uss_qualifier/scenarios/astm/utm/dss/fragments/sub/validate/mutated.md
Outdated
Show resolved
Hide resolved
Shastick
force-pushed
the
subs-fragments-doc-cleanup
branch
from
c0a5125 to
11039ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some subscription CRUD-related fragments were containing too many checks depending on the context in which they were used.
This PR ensures that only the checks actually being run are documented for some subscription scenarios.
Progress on #975