Skip to content

Conversation

@the-glu
Copy link
Contributor

@the-glu the-glu commented Jul 31, 2025

Contrib #1080

Switch to uv the small isort docker image. Not strictly need but for consistency ;)

Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 87a04d8.
LGTM modulo clarification in comment + update of PR title (this is also upgrading Python version) + rebase.

ADD . /app
WORKDIR /app

ENV UV_LINK_MODE=copy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need here to enforce the 'frozen' option? Or not since the dockerfile entrypoint is isort?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in that case we run python directly. Also in that specific light case (we just use the image to run the tool), performances is probably not needed, and the python version is not important, only the version of isort (I still updated the title nevertheless).

@the-glu the-glu changed the title [tooling] Switch isort docker image to UV [tooling] Switch isort docker image to UV + use latest python Aug 7, 2025
@the-glu the-glu force-pushed the switch_isort_to_uv branch from 87a04d8 to 0c151e0 Compare August 7, 2025 07:18
@the-glu the-glu force-pushed the switch_isort_to_uv branch from 0c151e0 to f173001 Compare August 7, 2025 07:32
@mickmis mickmis merged commit 916af6f into interuss:main Aug 7, 2025
20 checks passed
@mickmis mickmis deleted the switch_isort_to_uv branch August 7, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants