Skip to content

Conversation

@the-glu
Copy link
Contributor

@the-glu the-glu commented Jul 31, 2025

@the-glu the-glu force-pushed the upgrade_dependencies branch 2 times, most recently from babd317 to 4086fbe Compare August 5, 2025 13:54
Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4086fbe.
I do have some apprehension that such a mass upgrade could silently break some tooling/code paths not covered by the CI (e.g. test scenarios testing encryption of DB communications which directly use psycopg but is not ran in the CI). But the risk is probably acceptable so I'd tend to go ahead with the PR anyway.
@BenjaminPelletier any opinion?

Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed during InterUSS weekly: should be OK to go ahead and merge unless specific concern. If something breaks, it should be added in the CI.

I do have concerns about psycopg, notably checking out its release notes. Just 3.1.19 has changes in errors returned (https://www.psycopg.org/psycopg3/docs/news.html#psycopg-3-1-19). As we discussed, adding some unit tests testing the behavior of that scenario using psycopg should address those concerns.
What about:

  • not upgrading in this PR psycopg so that we can proceed with merging it
  • add unit test in follow-up for psycopg behavior we rely on
  • upgrade psycopg
    ?

@the-glu the-glu force-pushed the upgrade_dependencies branch from 584baec to 27bb99a Compare August 12, 2025 15:17
@the-glu
Copy link
Contributor Author

the-glu commented Aug 12, 2025

* not upgrading in this PR psycopg so that we can proceed with merging it
* add unit test in follow-up for psycopg behavior we rely on
* upgrade psycopg

Yes fine for me, I updated the lock file with psycopg not updated :)

@mickmis mickmis merged commit 6c7fdd3 into interuss:main Aug 12, 2025
20 checks passed
@mickmis mickmis deleted the upgrade_dependencies branch August 12, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants