Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 2, 2025

Bumps basedpyright from 1.31.5 to 1.31.6.

Commits
  • 52f52c7 1.31.6
  • cb45240 fix some typos in the Russian localization
  • 4c691c7 update convertToWorkspaceEdit and related functions to work with new tests ...
  • 6828884 update npm lockfile
  • 8230622 Merge tag '1.1.406' into merge-1.1.406
  • 308f5c0 Published 1.1.406
  • 38317d6 Fixed bug that results in false positive for module attributes that are synth...
  • 676cd11 Fixed several bugs related to subscripts with unpack operators, notably when ...
  • 8996f91 Removed remaining code that was left over from PEP 637, which was rejected.
  • f7285d9 Added special casing in reportUnnecessaryComparison check for modules. This...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [basedpyright](https://github.com/detachhead/basedpyright) from 1.31.5 to 1.31.6.
- [Release notes](https://github.com/detachhead/basedpyright/releases)
- [Commits](DetachHead/basedpyright@v1.31.5...v1.31.6)

---
updated-dependencies:
- dependency-name: basedpyright
  dependency-version: 1.31.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python:uv Pull requests that update python:uv code labels Oct 2, 2025
@BenjaminPelletier
Copy link
Member

@the-glu when I run make format on this branch, I get the errors:

  /app/monitoring/monitorlib/multiprocessing.py:65:19 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
  /app/monitoring/monitorlib/multiprocessing.py:72:13 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
  /app/monitoring/monitorlib/multiprocessing.py:83:9 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
  /app/monitoring/monitorlib/multiprocessing.py:86:9 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)

Upon investigation, it seems like basedpyright thinks SynchronizedValue._shared_memory might be None, but it's type-hinted as not None and the only time it is set is to a concrete instance (not None). Do you know what might be wrong?

@the-glu
Copy link
Contributor

the-glu commented Oct 2, 2025

Upon investigation, it seems like basedpyright thinks SynchronizedValue._shared_memory might be None, but it's type-hinted as not None and the only time it is set is to a concrete instance (not None). Do you know what might be wrong?

It's the _shared_memory.buf that may be None, not _shared_memory

image

I quickly tried locally and added a check on bufseems to do the trick, but since it's dues to existing fault you may also 'solve' it by writing the baseline file (uv run basedpyright --writebaseline) so it's fixed later :)

@BenjaminPelletier
Copy link
Member

Ah, I was looking one level too high -- thanks! Looks like basedpyright caught a typing error in the Python platform :)

@BenjaminPelletier BenjaminPelletier merged commit 4007d14 into main Oct 3, 2025
24 checks passed
@dependabot dependabot bot deleted the dependabot/uv/basedpyright-1.31.6 branch October 3, 2025 03:04
github-actions bot added a commit that referenced this pull request Oct 3, 2025
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin Pelletier <pelletierb@wing.com> 4007d14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python:uv Pull requests that update python:uv code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants