[mock_uss] Add user notifications for missing fields in injected flights #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-glu
force-pushed
the
user-notifications-missing-fields
branch
2 times, most recently
from
f5677c5 to
b6f033c
Compare
Shastick
approved these changes
Jan 30, 2025
Contributor
Shastick
left a comment
Shastick
left a comment
There was a problem hiding this comment.
Sounds like a wise thing to do :)
the-glu
force-pushed
the
user-notifications-missing-fields
branch
from
1988c8f to
eecc6f4
Compare
mickmis
reviewed
Jan 30, 2025
the-glu
force-pushed
the
user-notifications-missing-fields
branch
2 times, most recently
from
d3966b8 to
6fcca5a
Compare
mickmis
reviewed
Feb 4, 2025
the-glu
force-pushed
the
user-notifications-missing-fields
branch
from
6fcca5a to
9febd30
Compare
mickmis
reviewed
Feb 4, 2025
the-glu
force-pushed
the
user-notifications-missing-fields
branch
from
9febd30 to
fd6f219
Compare
mickmis
reviewed
Feb 5, 2025
the-glu
force-pushed
the
user-notifications-missing-fields
branch
from
fd6f219 to
aecd341
Compare
barroco
reviewed
Feb 6, 2025
Contributor
barroco
left a comment
barroco
left a comment
There was a problem hiding this comment.
Please see comments inline, otherwise, it looks good to me.
the-glu
force-pushed
the
user-notifications-missing-fields
branch
from
aecd341 to
83eaa9a
Compare
barroco
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #910
Tested, I added a filter + a new raw_telemetry field for internal purpose, because everything was crashing with bad telemetry data ^^'