Prepare leadtype package release#21
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (49)
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThis PR consolidates the leadtype monorepo by migrating the documentation domain from ChangesDomain migration, helper consolidation, and search enhancements
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3455f43288
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| export type SearchDocsOptions = ContentStoreOptions & { | ||
| limit?: number; | ||
| synonyms?: Record<string, string[]>; |
There was a problem hiding this comment.
Forward custom synonyms into answer contexts
Because AnswerContextOptions extends SearchDocsOptions, this new synonyms option is also advertised for createAnswerContext and the provider searchOptions, but createAnswerContext builds a fresh searchDocs options object and only forwards content and limit. In contexts where callers pass product-specific synonyms for answer generation, retrieval silently ignores them even though direct searchDocs calls honor them, so grounded answers can miss the intended sources.
Useful? React with 👍 / 👎.
Summary
leadtypepackage surface for release by lazy-loading optional TypeScript usage and moving bash search helpers behindleadtype/search/bash.leadtype0.1.0namedRelease leadtype.Validation
bun run --filter leadtype buildbun run --filter leadtype check-typesbun run --filter leadtype testbun run --filter leadtype lintbun run --filter example pipeline:buildbun run --filter example check-typesbun x ultracite checkbun pm pack --dry-runbun testpassed: 140 tests