-
Notifications
You must be signed in to change notification settings - Fork 34
Arm wheels and sdist #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm wheels and sdist #182
Conversation
| run: python -m pip install -r requirements.txt | ||
|
|
||
| - name: Compiling sdist | ||
| run: python setup.py sdist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably use python -m build --sdist
https://build.pypa.io/en/stable/index.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll look into it. I did build without sdist and it gave me errors. I'm struggling right now trying to emulate arm builds since github doesn't provide linux arm runners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah since I depend on dunamai and it requires git it won't work right now. I'll have to figure that out first since it looks like build isolates the build environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can build for Linux ARM using cibildwheel and QEMU, see https://cibuildwheel.pypa.io/en/stable/faq/#emulation
For build, you can use the '--no-isolation' switch until you figure out the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierreluctg I managed to get the CI working for the arm builds. I tested this against our neoVI PI with the CM4 to verify it actually works. --no-isolation gave me the same error so I'll have to see what the deal is there later. I'll open an issue to fix it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe consider moving from dunamai to setuptools_scm the PyPa recommended tool (https://setuptools-scm.readthedocs.io/en/stable/) ?

Arm wheels