Skip to content

Conversation

@drebbe-intrepid
Copy link
Collaborator

Arm wheels

run: python -m pip install -r requirements.txt

- name: Compiling sdist
run: python setup.py sdist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably use python -m build --sdist
https://build.pypa.io/en/stable/index.html

Copy link
Collaborator Author

@drebbe-intrepid drebbe-intrepid May 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll look into it. I did build without sdist and it gave me errors. I'm struggling right now trying to emulate arm builds since github doesn't provide linux arm runners.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah since I depend on dunamai and it requires git it won't work right now. I'll have to figure that out first since it looks like build isolates the build environment.

Copy link
Contributor

@pierreluctg pierreluctg May 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can build for Linux ARM using cibildwheel and QEMU, see https://cibuildwheel.pypa.io/en/stable/faq/#emulation

For build, you can use the '--no-isolation' switch until you figure out the issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierreluctg I managed to get the CI working for the arm builds. I tested this against our neoVI PI with the CM4 to verify it actually works. --no-isolation gave me the same error so I'll have to see what the deal is there later. I'll open an issue to fix it later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2024-05-24 23-52-36

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider moving from dunamai to setuptools_scm the PyPa recommended tool (https://setuptools-scm.readthedocs.io/en/stable/) ?

@drebbe-intrepid drebbe-intrepid merged commit 679fbbd into intrepidcs:master May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants