Correctly exposing floats from icsnVC40.h #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix the floats from icsnVC40.h like the timestamp scaling values where converted to integers.
Contributor
Author
|
Hi @drebbe-intrepid can you please let me know if this is the correct process to get a fix in this repo? Thank you |
Collaborator
|
Give me a few days and I'll look at it and test it then merge it. |
Collaborator
|
Thank you for catching this, initial testing looks good. Once I do complete testing I'll release a new version. |
Collaborator
|
This change is live in version 2.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix the floats from icsnVC40.h like the timestamp scaling
values where converted to integers.