Add logBundleSize script to calculate qbds/ids bundle size#718
Open
egcgt3 wants to merge 2 commits intointuit:masterfrom
Open
Add logBundleSize script to calculate qbds/ids bundle size#718egcgt3 wants to merge 2 commits intointuit:masterfrom
egcgt3 wants to merge 2 commits intointuit:masterfrom
Conversation
egcgt3
force-pushed
the
qboea-8155-measure-component-size
branch
from
6de9362 to
b134675
Compare
egcgt3
force-pushed
the
qboea-8155-measure-component-size
branch
from
d9bd955 to
67322fb
Compare
adierkens
reviewed
Aug 14, 2023
Comment on lines
+91
to
+92
| const canaryURL = `https://uxfabric.intuitcdn.net/components/design-systems/${repo}/canary/${prId}/${component}/ids.js`; | ||
| const distPath = `${componentsDir}/${component}/dist`; |
Collaborator
There was a problem hiding this comment.
These URLs don't look to be generic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Added logBundleSize.mjs to calculate QBDS and IDS component size while making a PR.
Why
Becuase we need to analyze the size difference between the PR and main files to see if the PR is going to add too much overhead