Skip to content

Conversation

@remojansen
Copy link
Member

Description

Fixes incorrect circular dependencies errors

Related Issue

#677
#543

Motivation and Context

#677
#543

How Has This Been Tested?

CI

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@remojansen
Copy link
Member Author

Blocked by nodejs/node#17684

@remojansen remojansen merged commit d015952 into master Dec 15, 2017
@remojansen remojansen deleted the circular-dependencies branch December 15, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants