Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/docs.page~448 Documentation is deployed and generated using docs.page. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request overhauls the design system and marketing pages, implementing a structured design token system and integrating shadcn/ui components. The homepage and 'Get Started' layouts are redesigned, supported by new UI components and a centralized link constant file. The PR also updates the Biome configuration, introduces new cursor rules, and removes several obsolete components. API changes include refactoring for type safety and import reordering. Review feedback identified a logic error in the rehypeInlineBadges plugin, a file extension mismatch for an SVG asset, an unused function in CodeGroup.tsx, and a UX improvement to remove controls from the auto-playing hero video.
| function visitor(node: NodeWithChildren) { | ||
| function visitor(node: HastNode) { | ||
| if (!isElementWithVisited(node)) return; | ||
| node.visited === "true"; |
There was a problem hiding this comment.
This comparison node.visited === "true" has no effect. It seems you intended to perform an assignment to mark the node as visited, like node.visited = "true";. Without this, the check in containsBadge might not work as expected in all scenarios.
| node.visited === "true"; | |
| node.visited = "true"; |
| @@ -0,0 +1,24 @@ | |||
| <svg width="677" height="677" viewBox="0 0 677 677" fill="none" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | |||
There was a problem hiding this comment.
This file has a .png extension but its content is SVG markup. This is misleading and could cause issues for browsers or asset processors that rely on the file extension to determine the content type. Please consider renaming the file to large-icon.svg.
| function _getCodeGroupKey(context: Context, value: string) { | ||
| return context.preview | ||
| ? `preview:code-group:${value}` | ||
| : `docs.page:code-group:${context.owner}/${context.repository}:${value}`; |
There was a problem hiding this comment.
The function _getCodeGroupKey appears to be unused within this file. If it's not used elsewhere, it could be removed to clean up the code.
| loop | ||
| muted | ||
| playsInline | ||
| controls |
There was a problem hiding this comment.
Including controls on an auto-playing background video might not be the intended user experience, as it can overlay the video content with player controls. If this video is purely for background aesthetic, consider removing the controls attribute.
3 participants
V3 with Invertase brand styling