Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/docs.page~453 Documentation is deployed and generated using docs.page. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive design system update, including new design token structures, UI best practices, and a significant overhaul of the marketing homepage components. The changes include adding new SVG assets, updating Tailwind configurations, and refactoring several UI components to use a consistent variant architecture. My feedback highlights a bug in the rehype-inline-badges plugin where a comparison was used instead of an assignment, and suggests using semantic tokens for background colors in the PlatformFeatureCard component to ensure theme consistency.
| function visitor(node: NodeWithChildren) { | ||
| function visitor(node: HastNode) { | ||
| if (!isElementWithVisited(node)) return; | ||
| node.visited === "true"; |
There was a problem hiding this comment.
The assignment node.visited === "true" is a comparison, not an assignment. It should be node.visited = "true";.
| node.visited === "true"; | |
| node.visited = "true"; |
| /* Full-card inset tint from `platformCardVariants` darkens art; overlay tiles skip it. */ | ||
| "relative overflow-hidden !shadow-none", | ||
| /* Light mode: `bg-card` + `from-background` scrim read as white behind dark art — use black. */ | ||
| "!bg-black dark:!bg-marketing-platform-inner-dark", |
There was a problem hiding this comment.
The hardcoded background color !bg-black in dark mode might conflict with the theme system. Consider using a semantic token if available.
2 participants
typography update