Conversation
…arseArrays are cleared during module teardown
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request introduces null checks in the stopTrace, stopScreenTrace, and stopHttpMetric methods within UniversalFirebasePerfModule.java. These additions prevent potential NullPointerExceptions that might occur if traces or metrics are cleared during module teardown before the JavaScript layer stops them. I have no feedback to provide.
mikehardy
left a comment
There was a problem hiding this comment.
seems like a reasonable approach
confirmed that at the JS layer the pathway is always:
1- verify arguments and such before calling down to native
2- return the result of a call to native
And in native all pathways were
1- do things
2- always return null
So adding null safety here then returning null is a graceful way to handle it
|
macOS CI failure unrelated, see: Non-blocking |
Description
fixes #8938
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter