[Bugfix] Renames in 0.15.0 diffusers #3184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imports: `diffusers.models.cross_attention -> diffusers.models.attention_processor` Unions: `AttnProcessor -> AttentionProcessor` Classes: | Old name | New name| | --- | --- | | CrossAttention | Attention | | CrossAttnProcessor | AttnProcessor | | XFormersCrossAttnProcessor | XFormersAttnProcessor | | CrossAttnAddedKVProcessor | AttnAddedKVProcessor | | LoRACrossAttnProcessor | LoRAAttnProcessor | | LoRAXFormersCrossAttnProcessor | LoRAXFormersAttnProcessor | Same names in this class: `SlicedAttnProcessor, SlicedAttnAddedKVProcessor`
StAlKeR7779
requested review from
blessedcoolant,
damian0815 and
keturn
as code owners
StAlKeR7779
commented
Apr 12, 2023
Contributor
Author
|
@lstein, @blessedcoolant Looks like i'm done with it. |
Collaborator
|
Great and thanks! As I noted in Discord, I'm going to do a hotfix
2.3.4.post1 release with pinned 0.14 today, and then a 2.3.5 release with
your PR merged to allow time for a pre-release and end-user testing.
Lincoln
|
lstein
approved these changes
Apr 14, 2023
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
I committed a couple of small fixes, and have a question about the use of self.config above. Otherwise looks great and passed a bit of testing.
lstein
added a commit
that referenced
this pull request
Apr 14, 2023
- This is a port of #3184 to the main branch
ebr
approved these changes
Apr 16, 2023
Collaborator
|
@damian0815 , @blessedcoolant We'll need a codeowner review on this. Thanks! |
blessedcoolant
approved these changes
Apr 19, 2023
Collaborator
|
@damian0815 @blessedcoolant We need a codeowner review on this PR. Thanks! |
blessedcoolant
approved these changes
Apr 20, 2023
- Change diffusers dependency to `diffusers~=0.15.0` which *should* enforce non-breaking changes.
blessedcoolant
approved these changes
Apr 20, 2023
lstein
added a commit
that referenced
this pull request
Apr 25, 2023
- This is a port of #3184 to the main branch
GreggHelt2
approved these changes
Apr 27, 2023
Contributor
GreggHelt2
left a comment
GreggHelt2
left a comment
There was a problem hiding this comment.
Looks good. And thanks for the clear explanation of class renaming etc in the PR message!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to PR in diffusers repository:
huggingface/diffusers#2691
Imports:
diffusers.models.cross_attention -> diffusers.models.attention_processorUnions:
AttnProcessor -> AttentionProcessorClasses:
Also config values no longer sets as attributes of object:
huggingface/diffusers#2849