Make API client async #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mahesh209
reviewed
Aug 7, 2024
There was a problem hiding this comment.
Something for the future but we should replace the usage of Exception with a custom exception.
Mahesh209
approved these changes
Aug 7, 2024
Mahesh209
left a comment
Mahesh209
left a comment
There was a problem hiding this comment.
Everything is now async as intended. I like the inclusion of the changelog and installation instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the Clockify API client from synchronous to asynchronous operation.
This is done by replacing
requestscalls with async calls to httpx.A matching branch should be merged for timekeeper when this PR is merged.
How to test this PR
A sandbox API key can be generated for testing by logging in as dev@ion8.net at https://developer.marketplace.cake.com, then using the "Log in as" button for the admin account shown in the sandbox user list. In that user's settings, click Advanced and generate a temporary API key. The code sample in the README will work with this key.