Skip to content

chore(splash-screen): use getConfig instead of getConfigValue #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcesarmobile merged 2 commits into from
May 12, 2022
Merged

chore(splash-screen): use getConfig instead of getConfigValue #962

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96020be
chore(splash-screen): use getConfig instead of getConfigValue
jcesarmobile May 9, 2022
7da5ffc
without labels
jcesarmobile May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions splash-screen/ios/Plugin/SplashScreenPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,30 +58,24 @@ public class SplashScreenPlugin: CAPPlugin {
private func splashScreenConfig() -> SplashScreenConfig {
var config = SplashScreenConfig()

if let backgroundColor = getConfigValue("backgroundColor") as? String {
if let backgroundColor = getConfig().getString("backgroundColor") {
config.backgroundColor = UIColor.capacitor.color(fromHex: backgroundColor)
}
if let spinnerStyle = getConfigValue("iosSpinnerStyle") as? String {
if let spinnerStyle = getConfig().getString("iosSpinnerStyle") {
switch spinnerStyle.lowercased() {
case "small":
config.spinnerStyle = .white
default:
config.spinnerStyle = .whiteLarge
}
}
if let spinnerColor = getConfigValue("spinnerColor") as? String {
if let spinnerColor = getConfig().getString("spinnerColor") {
config.spinnerColor = UIColor.capacitor.color(fromHex: spinnerColor)
}
if let showSpinner = getConfigValue("showSpinner") as? Bool {
config.showSpinner = showSpinner
}
config.showSpinner = getConfig().getBoolean("showSpinner", config.showSpinner)

if let launchShowDuration = getConfigValue("launchShowDuration") as? Int {
config.launchShowDuration = launchShowDuration
}
if let launchAutoHide = getConfigValue("launchAutoHide") as? Bool {
config.launchAutoHide = launchAutoHide
}
config.launchShowDuration = getConfig().getInt("launchShowDuration", config.launchShowDuration)
config.launchAutoHide = getConfig().getBoolean("launchAutoHide", config.launchAutoHide)
return config
}

Expand Down