Skip to content

Comments

fix: resolve content uri when Hostname includes port#321

Merged
jcesarmobile merged 1 commit intoionic-team:masterfrom
adityak74:fix--openContentUri-string-relace-fixes-for-including-port
Mar 26, 2019
Merged

fix: resolve content uri when Hostname includes port#321
jcesarmobile merged 1 commit intoionic-team:masterfrom
adityak74:fix--openContentUri-string-relace-fixes-for-including-port

Conversation

@adityak74
Copy link
Contributor

@adityak74 adityak74 commented Mar 1, 2019

This PR resolves issues with resolving assets. realPath string replace fails as the Hostname for example be localhost:8080.

jcesarmobile
jcesarmobile approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jcesarmobile jcesarmobile merged commit fdfe8aa into ionic-team:master Mar 26, 2019
Ionitron added a commit that referenced this pull request Mar 26, 2019
@Ionitron
chore(release): 4.0.1 [skip ci]
c61e4d5 
## [4.0.1](v4.0.0...v4.0.1) (2019-03-26)

### Bug Fixes

* **ios:** Fix autofocus on iOS 12.2 ([#334](#334)) ([cb4c491](cb4c491)), closes [#330](#330)
* account port on resolving uri path ([#321](#321)) ([fdfe8aa](fdfe8aa))
@Ionitron
Copy link
Collaborator

Ionitron commented Mar 26, 2019

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adityak74 @Ionitron @jcesarmobile