the '-b' flag is not being respected in v3

[sfabriece]

What version of the CLI are you using? Output of ionic --version

3.0.0-rc.1

Short description of the problem:

the following command opens the browser.

ionic serve -scb --lab

What behavior are you expecting?

I expect the command to run without a browser tab being opened.

Post the output of ionic info below please

global packages:

    @ionic/cli-utils : 1.0.0-rc.1
    Ionic CLI        : 3.0.0-rc.1

local packages:

    @ionic/app-scripts              : 1.3.7
    @ionic/cli-plugin-ionic-angular : 1.0.0-rc.1
    Ionic Framework                 : ionic-angular 3.1.1

System:

    Node       : v7.8.0
    OS         : Windows 10
    Xcode      : not installed
    ios-deploy : not installed
    ios-sim    : not installed

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

output after running the command.

Starting app-scripts server: --consolelogs --serverlogs --nobrowser --lab --port 8100 --livereload-port 35729 --address 0.0.0.0

[imhoffd]

Right now --lab overrides -b. It doesn't make sense to supply both flags, as --lab is a feature for the launched browser.

What do you expect to happen when both flags are supplied?

[sfabriece]

since I can always go to the 'lab' using the url '/ionic-lab', I expect passing -b to mean, I explicitly don't want to open the browser because I know which Urls to go to.

For example if i already have the browser open with the right url

[imhoffd]

Gotcha @sfabriece, I understand 👍

@danbucholtz Can we review this line here: https://github.com/driftyco/ionic-app-scripts/blob/c17e6dfa132039e92c6cc3042a38183ffeb531dc/src/serve.ts#L76

[imhoffd]

@sfabriece Probably won't be fixed for v3 launch, but we'd like to fix this in the future.

[sfabriece]

sounds good @dwieeb. Should i close this issue?

[imhoffd]

@sfabriece If you don't mind I'll keep it open under the milestone.

[imhoffd]

Hi @sfabriece, I finally got around to this. It will be fixed in 3.7 for both Ionic 1 and Ionic Angular.

[sfabriece]

awesome @dwieeb