docs: add stackblitz playground for theming#1648
Closed
Coly010 wants to merge 1 commit intoionic-team:mainfrom
Closed
docs: add stackblitz playground for theming#1648Coly010 wants to merge 1 commit intoionic-team:mainfrom
Coly010 wants to merge 1 commit intoionic-team:mainfrom
Conversation
Contributor
|
Thank you for the PR! We greatly appreciate the work you've put in. In the time since this was posted, we've updated the docs with playgrounds/live demos that include code for all major frameworks Ionic supports. (You can see examples on the component docs, such as here.) Rather than link to additional sandboxes, we should replace the ones on this page with equivalent playgrounds. This will also include example code for Vue. I've created #2998 to track this work effort, and raised it internally with the team. I've also made sure to add a note about your PR so that we can give you co-author credit when adding the new demos. I'm going to close this out in lieu of the above changes, but let me know if you have any questions, and thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add stackblitz for theming and manual dark mode docs for Angular and React
Link to stackblitz
Angular - https://stackblitz.com/edit/ionic-ng-theming
React - https://stackblitz.com/edit/ionic-react-theming
Screenshots