docs(animations): add React and Angular example for keyframe animations#1689
Closed
dillionmegida wants to merge 2 commits intoionic-team:mainfrom
dillionmegida:docs/keyframe-animations
Closed
docs(animations): add React and Angular example for keyframe animations#1689dillionmegida wants to merge 2 commits intoionic-team:mainfrom dillionmegida:docs/keyframe-animations
dillionmegida wants to merge 2 commits intoionic-team:mainfrom
dillionmegida:docs/keyframe-animations
Conversation
People with color defects may not be able to see the animation properly, so I changed it to something more perceivable
Contributor
|
It should be noted the keyframe transition properties were changed from a colour to a transform for a11y reasons |
Contributor
Author
I stated that in the commit message though. Have you seen it? |
Contributor
|
Hi, thank you for your contribution! I've rebuilt this using our new playground structure in #3039 and given you co-author credit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add StackBlitz live example for Keyframe Animations
StackBlitz
Angular - https://stackblitz.com/edit/ionic-angular-animation-keyframes
React - https://stackblitz.com/edit/ionic-react-animation-keyframes