docs(animations): add React and Angular example for overriding animations#1704
Closed
dillionmegida wants to merge 1 commit intoionic-team:mainfrom
dillionmegida:docs/override-animations
Closed
docs(animations): add React and Angular example for overriding animations#1704dillionmegida wants to merge 1 commit intoionic-team:mainfrom dillionmegida:docs/override-animations
dillionmegida wants to merge 1 commit intoionic-team:mainfrom
dillionmegida:docs/override-animations
Conversation
…ions Also, fix missing import - `createAnimation`
Contributor
|
Thank you for the PR, and apologies for the delay! We appreciate you contributing to Ionic. Since this PR was opened we have added "playgrounds" to our docs which provide interactive demos of code, per-JS Framework code snippets, and a link to open the code snippets in StackBlitz. As a result, I have opened #3018 to create a playground for the "Override Animations" demo. I am going to close this in favor of the linked PR, but I will give you co-author credit when this PR merges. Let me know if you have any questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add StackBlitz live example for Overriding Ionic Components Animations
Also, fix missing import -
createAnimationStackBlitz
Angular - https://stackblitz.com/edit/ionic-angular-animation-override
React - https://stackblitz.com/edit/ionic-react-animation-overwride