docs(react): Clarify the Ionic Lifecycle Methods documentation#2178
Closed
BAYiTUPAi wants to merge 1 commit intoionic-team:mainfrom
Closed
docs(react): Clarify the Ionic Lifecycle Methods documentation#2178BAYiTUPAi wants to merge 1 commit intoionic-team:mainfrom
BAYiTUPAi wants to merge 1 commit intoionic-team:mainfrom
Conversation
I think the ionViewDidLeave should state "from" not "to". Also added italics to make it clear what's different between the methods. Note - I'm reading the docs for a reason! :D if this change is wrong please someone correct me.
|
@BLACKSHiRTSQUAD is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
BAYiTUPAi
changed the title
Contributor
|
Hey there, Apologies for the delay. We appreciate you making this PR! I took your changes and applied them to all of our lifecycle guides in #2951. This PR was merged, and I gave you co-author credit in a72013d. I am going to close this PR in favor of the one that was merged, but let me know if you have any questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the ionViewDidLeave should state "from" not "to". Also added italics to make it clear what's different between the methods.
Note - I'm reading the docs for a reason! :D if this change is wrong please someone correct me.