WIP: add some documentation on IonicSlides#2458
Closed
arnotixe wants to merge 1 commit intoionic-team:mainfrom
Closed
WIP: add some documentation on IonicSlides#2458arnotixe wants to merge 1 commit intoionic-team:mainfrom
arnotixe wants to merge 1 commit intoionic-team:mainfrom
Conversation
WIP: would be great to have some documentation on IonicSlides actually do. Migrating from ion-slides I got the regression that pinch zoom on mobiles work, but doubleclick to zoom (desktop) stopped working. Puzzled because https://swiperjs.com/types/interfaces/types_modules_zoom.zoomoptions says toggle is default true - and then I came to think about IonicSlides. Not sure this is the best place to put it though, but it would be convenient with a list of what settings IonicSlides overrides somewhere, and link to it.
|
@arnotixe is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
thetaPC
requested changes
Apr 12, 2023
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
The requested changes will also need to be applied to:
- the rest of the frameworks (React and Vue)
- version 6 (
version_docs/version-6/FRAMEWORK/slides.md)
| ## The IonicSlides Module | ||
|
|
||
| With `ion-slides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. | ||
| With `ion-slides`, Ionic automatically customized dozens of Swiper properties, for example turning off zoom on doubleclick. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. |
Contributor
There was a problem hiding this comment.
Instead of using an example, let's mention in the docs to review the provided properties from IonicSlides.tsx. This would allow users to quickly reference what properties are being set through IonicSlides Module.
I would recommend adding it to the end of the paragraph.
Contributor
|
Closing in favor of this up-to-date PR: #2934 |
Contributor
|
Thanks for the issue! This has been resolved via #2934 and will be available soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: would be great to have some documentation on IonicSlides actually do. Migrating from ion-slides I got the regression that pinch zoom on mobiles work, but doubleclick to zoom (desktop) stopped working. Puzzled because https://swiperjs.com/types/interfaces/types_modules_zoom.zoomoptions says toggle is default true - and then I came to think about IonicSlides.
Not sure this is the best place to put it though, but it would be convenient with a list of what settings IonicSlides overrides somewhere, and link to it.